[ZP-12866] Use FakeR instead of R.java #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidofwatkins
approved these changes
Aug 30, 2023
davidofwatkins
left a comment
davidofwatkins
left a comment
There was a problem hiding this comment.
lgtm! Glad it was a relatively easy fix!
package.json
Outdated
| { | ||
| "name": "@zenput/cordova-plugin-image-picker", | ||
| "version": "22.10.20-H17M24S13", | ||
| "version": "23.8.30-H08M20S22", |
There was a problem hiding this comment.
Unlike Zencam, I don't think we have CI set up to deploy this automatically on merge to main. So, I think you'll have to manually run this from your local:
npm run calversion
npm publishI would do that from this PR just before you merge to main instead of after, since it will make a diff in the code that needs to be committed. (This is from memory, so I may be slightly off. We should really document the publishing process in the README.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to test it